ExecutionContextProvider
object ExecutionContextProvider
For the Shiftleft SAAS offering, we are using non-inherited thread-local MDC (message diagnostic context) in order to relate log messages to artifacts. The same JVM process is concurrently processing multiple customer artifacts.
In order to make this work, every long-running analysis gets its own MDCAwareExecutor, i.e. its own threadpool.
So all multi-threading in codepropertygraph must make sure to either:
- Code that uses
new Thread
must set up MDC correctly. For example, consider the Writer background-threads spawned in ParallelCpgPass.scala, or consider the background-threads spawned in overflowdb. 2. Code that directly (or scala-implicitly) uses threadpools / scala-style executors / java-style ExecutorService should call e.g.implicit val ec:ExecutionContextExecutor = io.shiftleft.utils.ExecutionContextProvider.getExecutionContext
instead ofimplicit val ec:ExecutionContextExecutor = scala.concurrent.ExecutionContext.global
orimport scala.concurrent.ExecutionContext.Implicits
3. Code that uses java parallel stream (e.g. ForkJoinParallelCpgPass) needs no changes -- the java stream standard library automatically picks up the right threadpool that sets up MDC correctly.